Skip to content

Display missing route details.#1363

Merged
lovelydinosaur merged 9 commits intoKludex:masterfrom
alex-oleshkevich:improve-notfound-exception
Feb 14, 2022
Merged

Display missing route details.#1363
lovelydinosaur merged 9 commits intoKludex:masterfrom
alex-oleshkevich:improve-notfound-exception

Conversation

@alex-oleshkevich
Copy link
Contributor

This PR improves error reporting for NoMatchFound exception.
image

@Kludex
Copy link
Owner

Kludex commented Dec 14, 2021

For the record, this is what we have before this PR:

image

@Kludex Kludex mentioned this pull request Dec 20, 2021
8 tasks
@adriangb adriangb added the feature New feature or request label Feb 2, 2022
@lovelydinosaur
Copy link

This is a clear win, yup!

Do we think we need to be concerned about folks raising NoMatchFound() directly in their own codebases, and continue to support but deprecate that case? (I don't think we document it anywhere, so arguably it's private-enough-ish not to be too concerned about this?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants